Support account deletion for SIWA and with store creation features enabled #8179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
1 task
* trunk: (104 commits) Store configured NumberFormatter as static property Removed custom init from ButtonActivityIndicator Move divider spacing into constants Link viewmodel into existing code Adds convinience extension for the VM Rename StartCards filename to AnalyticsReportCardData Adds type to transmit report card data Update naming Fix linter violation Update naming Update naming Prefer delta over Growth Update domain selector view conditional logic with a state enum in the view model. Add helpers for calculating the delta percentage for specific analytics stats Simplify block with Result extension Remove trailing whitespace Simplify mocks with result.get() Simplify code with try? Add helpers for calculating the delta percentage for stats Update domain search placeholder. ... # Conflicts: # WooCommerce/Classes/Authentication/Epilogue/StorePickerViewController.swift # WooCommerce/Classes/ViewRelated/Dashboard/Settings/Settings/SettingsViewController.swift # WooCommerce/WooCommerceTests/ViewRelated/Settings/CloseAccountCoordinatorTests.swift
* trunk: (386 commits) Replace escaped `U+2011` with actual character in a localized string Bump version number Update metadata translations Update app translations – `Localizable.strings` Update logged-out A/A test name and re-add logged-in A/A test. Update `MockInAppPurchases` `fetchProductsDuration` to nanoseconds instead of seconds. Try increasing `fetchProductsDuration` to fix the flaky test with a debug log. Add back a line that indicates that the account creation task is in progress as a regression from a previous refactoring. Animate navigation to store picker with store creation configuration. Adjust column inner spacing Add custom formatters to tests Add tests Inject numberOfFractionDigits as a function parameter Use the number of fraction digits from the store settings Use existing rounding extension in StatsDataTextFormatter Bump version number Use the correct stats order Update tests Update StatsDataTextFormatter to round decimals to significant numbers Bump version number ... # Conflicts: # WooCommerce/Classes/Authentication/Epilogue/EmptyStoresTableViewCell.xib
Contributor
Author
|
When testing in iOS 16.1 iPhone 14 simulator, I encountered an issue when showing an alert with a text field: There's a similar question in the developer forum. This isn't an issue in iOS 16.0 simulators, another iOS 16.1 simulator, and an iOS 16.1 device that I tested. I'm going to assume that this is a bug in the simulator, and file a bug. |
Collaborator
You can test the changes from this Pull Request by:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8178
Description
Previously, we implemented account deletion only for users who signed in with Apple (SIWA) #7068. Now that we just added account creation #7891, we should also allow any user to delete their account in the app to comply with Apple requirements.
In place of
hasAppleUserID()inSettingsViewModelandStorePickerViewController, two other conditions were added asORwhen thestoreCreationMVPandstoreCreationM2feature flags are enabled.Testing instructions
Without a connected store
Prerequisite: the WP.com account isn't connected to any WC stores (you can sign up for an account in the app and then dismiss the store creation flow)
Close AccountCTA on the empty store pickerClose Account--> a confirmation alert should be shown with a text fieldPermanently Close Accountto confirm --> an in-progress UI modal should be shown and then dismissed, and the app is back to the beginning of the login screen if the closure is successful. If there's an error (e.g. A8C account or the account owns an atomic site), an error alert should be shownWith a connected store
Prerequisite: the WP.com account is connected to at least one WC store.
Close Account--> a confirmation alert should be shown with a text fieldPermanently Close Accountto confirm --> an in-progress UI modal should be shown and then dismissed, and the app is back to the beginning of the login screen if the closure is successful. If there's an error (e.g. A8C account or the account owns an atomic site), an error alert should be shownScreenshots
RELEASE-NOTES.txtif necessary.